LG-12804: add ID photo and selfie content change. by dawei-nava · Pull Request #10348 · 18F/identity-idp

dawei-nava · 2024-04-01T18:16:47Z

🎫 Ticket

Link to the relevant ticket:
LG-12804

🛠 Summary of changes

Update instruction and tips for taking ID photos and selfie.

📜 Testing Plan

Provide a checklist of steps to confirm the changes.

Scenario 1:
Non Selfie Desktop:

Step 1: Login with SP without biometric option
Step 2: Proceed to document capture page.
Step 3: Verify ID part new tip list and sub-header

Scenario 2:

Non Selfie Mobile:

Step 1: Login with SP without biometric option
Step 2: Proceed to document capture page.
Step 3: Verify ID part sub-header and new tip list(should have no file size 2Mb entry)

Scenario 3:

Selfie Mobile:

Step 1: Login with SP with biometric option
Step 2: Proceed to document capture page.
Step 3: Verify ID part sub-header and new tip list(should have no file size 2Mb entry)
Step 4: Verify Selfie part , header , content, and tip list etc.

👀 Screenshots

If relevant, include a screenshot or screen capture of the changes.

Before:

Non Selfie Desktop	Non Selfie Mobile

After:

Non Selfie Desktop

En	Es	Fr

Non Selfie Mobile

En	Es	Fr

Selfi Mobile ID portion

En	Es	Fr

Selfi Mobile Selfie portion

En	Es	Fr

changelog: User-Facing Improvements, Doc Auth, Page content changes for document and selfie capture.

app/javascript/packages/document-capture/components/documents-step.tsx

eileen-nava

I started to review this, but I am going to hold off on finishing the review because the ticket is now blocked.

eileen-nava · 2024-04-03T15:05:45Z

app/javascript/packages/document-capture/components/document-capture-review-issues.tsx

    <>
      <PageHeading>{t('doc_auth.headings.review_issues')}</PageHeading>
-      <DocumentCaptureSubheaderOne isSelfieCaptureEnabled={isSelfieCaptureEnabled} />
+      {isSelfieCaptureEnabled && (


config/locales/doc_auth/en.yml

eileen-nava · 2024-04-03T15:22:25Z

spec/javascript/packages/document-capture/components/documents-step-spec.jsx

    expect(back).to.be.ok();
    expect(pageHeader).to.be.ok();
-    expect(idHeader).to.be.ok();
+    expect(idHeader).to.be.not.ok();


eileen-nava

LGTM, approved.

eileen-nava · 2024-04-08T14:39:11Z

config/locales/doc_auth/en.yml

-      document_capture_selfie_text3: Take your photo in a well-lit place
+      document_capture_id_text1: Place your ID on a flat and dark surface.
+      document_capture_id_text2: Take your photo in a well-lit place.
+      document_capture_id_text3: Avoid glare or shadows on your ID.


I tested locally and these tips looked like the figma. 👍🏻

eileen-nava · 2024-04-08T14:41:58Z

config/locales/doc_auth/es.yml

-      document_capture_selfie_text3: Tómese la foto en un sitio con buena iluminación
+      document_capture_id_text1: Coloque su identificación en una superficie plana y de color oscuro.
+      document_capture_id_text2: Tómese la foto en un lugar bien iluminado.
+      document_capture_id_text3: Evite que se vean reflejos o sombras en su identificación.


I tested locally and the tips looked as expected. 👍🏻

eileen-nava · 2024-04-08T14:44:26Z

config/locales/doc_auth/fr.yml

      document_capture_hint: Doit être un JPG ou PNG
      document_capture_id_text1: Placez votre pièce d’identité sur une surface plane et sombre.
-      document_capture_id_text2: Prenez la photo sur une surface plane
+      document_capture_id_text2: Prenez votre photo dans un endroit bien éclairé.


Looked as expected when tested locally. 👍🏻

eileen-nava · 2024-04-08T15:00:13Z

config/locales/doc_auth/en.yml

+        might cover your face. We suggest removing your glasses or hat.
+      document_capture_selfie_text2: Take your photo in a well-lit place.
+      document_capture_selfie_text3: Keep your expression neutral.
+      document_capture_selfie_text4: Make sure your whole face is visible within the green circle.


Looks good in local testing. 👍🏻

eileen-nava · 2024-04-08T15:05:31Z

config/locales/doc_auth/es.yml

+        cubrirle la cara. Sugerimos que se quite los anteojos o el sombrero.
+      document_capture_selfie_text2: Tómese la foto en un lugar bien iluminado.
+      document_capture_selfie_text3: Mantenga una expresión neutral.
+      document_capture_selfie_text4: Revise que se vea su rostro completo dentro del círculo verde.


Looks good in local testing. 👍🏻

eileen-nava · 2024-04-08T15:07:30Z

config/locales/doc_auth/fr.yml

      review_issues: Vérifiez vos images et essayez à nouveau
      secure_account: Sécuriser votre compte
-      selfie: Photo
+      selfie: Photo de votre visage


Looks good locally. 👍🏻

dawei-nava · 2024-04-08T17:01:48Z

@kellular can you take a look?

kellular

I cross-referenced the PR updates with the DOS translations, and everything here LGTM.

daviddsilvanava · 2024-04-10T13:37:26Z

@kellular could you send this to LQA please? How do you want to track that? Maybe move the ticket in jira back to blocked?

kellular · 2024-04-10T14:10:50Z

@daviddsilvanava Yes I can send this through LQA. Moving the Jira ticket back to blocked works for me!

dawei-nava requested review from amirbey, charleyf, eileen-nava, kellular and night-jellyfish April 2, 2024 13:28

dawei-nava added 2 commits April 2, 2024 10:09

LG-12804: add ID photo and selfie content change.

7e41302

changelog: User-Facing Improvements, Doc Auth, Page content changes for document and selfie capture.

LG-12804: No subheader for ID photo when no selfie required.

841661b

dawei-nava force-pushed the dwang/LG-12804_add_photo_texts branch from 1096213 to 841661b Compare April 2, 2024 14:21

dawei-nava marked this pull request as ready for review April 2, 2024 14:52

aduth reviewed Apr 2, 2024

View reviewed changes

app/javascript/packages/document-capture/components/documents-step.tsx Outdated Show resolved Hide resolved

eileen-nava reviewed Apr 3, 2024

View reviewed changes

dawei-nava added 2 commits April 5, 2024 17:30

LG-12804: typo etc.

ee56702

LG-12804: update with DOS translations.

1505ea4

eileen-nava self-requested a review April 8, 2024 14:03

eileen-nava approved these changes Apr 8, 2024

View reviewed changes

kellular approved these changes Apr 9, 2024

View reviewed changes

dawei-nava merged commit 3a793c3 into main Apr 9, 2024

dawei-nava deleted the dwang/LG-12804_add_photo_texts branch April 9, 2024 17:49

solipet mentioned this pull request Apr 11, 2024

Deploy RC 371 to Production #10414

Merged

Conversation

dawei-nava commented Apr 1, 2024 • edited by eileen-nava Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎫 Ticket

🛠 Summary of changes

📜 Testing Plan

👀 Screenshots

Uh oh!

Uh oh!

eileen-nava left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

eileen-nava left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dawei-nava commented Apr 8, 2024

Uh oh!

kellular left a comment

Choose a reason for hiding this comment

Uh oh!

daviddsilvanava commented Apr 10, 2024

Uh oh!

kellular commented Apr 10, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

dawei-nava commented Apr 1, 2024 •

edited by eileen-nava

Loading