Skip to content

Fixing spec issues related to How to Verify page changes#10345

Merged
JackRyan1989 merged 3 commits intomainfrom
jryan/how_to_verify_spec_bug_fix
Apr 1, 2024
Merged

Fixing spec issues related to How to Verify page changes#10345
JackRyan1989 merged 3 commits intomainfrom
jryan/how_to_verify_spec_bug_fix

Conversation

@JackRyan1989
Copy link
Contributor

🎫 Ticket

No ticket. Noticed a few failing specs and realized they were related to some changes done to the How To Verify page and supporting specs. This pr should get the specs back to green.

@JackRyan1989 JackRyan1989 requested review from a team and dawei-nava April 1, 2024 15:45
@JackRyan1989 JackRyan1989 self-assigned this Apr 1, 2024
@JackRyan1989 JackRyan1989 requested a review from n1zyy April 1, 2024 15:45
@JackRyan1989 JackRyan1989 changed the title fixing small spec issues related to how to verify page changes Fixing spec issues related to How to Verify page changes Apr 1, 2024
Copy link
Contributor

@n1zyy n1zyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the changelog entry I watched you compose somehow didn't get attached, but otherwise, :shipit: this fixes multiple failures and is nice and simple.

Copy link
Contributor

@dawei-nava dawei-nava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@JackRyan1989 JackRyan1989 merged commit 123bc45 into main Apr 1, 2024
@JackRyan1989 JackRyan1989 deleted the jryan/how_to_verify_spec_bug_fix branch April 1, 2024 17:30
@aduth aduth mentioned this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants