18F · mitchellhenke · Apr 2, 2024 · Mar 29, 2024 · Mar 29, 2024 · aduth
diff --git a/.erb-lint.yml b/.erb-lint.yml
@@ -15,6 +15,8 @@ linters:
         Enabled: false
       Lint/UselessAssignment:
         Enabled: false
+      Style/FrozenStringLiteralComment:
+        Enabled: false
   DeprecatedClasses:
     enabled: true
     rule_set:

diff --git a/.rubocop.yml b/.rubocop.yml
@@ -1127,6 +1127,16 @@ Style/For:
   Enabled: true
   EnforcedStyle: each
 
+Style/FrozenStringLiteralComment:
+  Enabled: true
+  Exclude:
+    - 'spec/**/*.rb'
+    - '.irbrc'
+    - '.rubocop.yml'
+    - 'Brewfile'
+    - 'Gemfile'
+    - 'Rakefile'
+
 Style/GlobalVars:
   Enabled: true
   AllowedVariables: []

diff --git a/app/components/accordion_component.rb b/app/components/accordion_component.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class AccordionComponent < BaseComponent
   renders_one :header
 

diff --git a/app/components/alert_component.rb b/app/components/alert_component.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class AlertComponent < BaseComponent
   VALID_TYPES = %i[info success warning error emergency other].freeze
 

diff --git a/app/components/alert_icon_component.rb b/app/components/alert_icon_component.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class AlertIconComponent < BaseComponent
   ICON_SOURCE = {
     warning: 'status/warning.svg',

diff --git a/app/components/badge_component.rb b/app/components/badge_component.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class BadgeComponent < BaseComponent
   ICONS = %i[
     unphishable

diff --git a/app/components/barcode_component.rb b/app/components/barcode_component.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'barby'
 require 'barby/barcode/code_128'
 require 'barby/outputter/html_outputter'

diff --git a/app/components/base_component.rb b/app/components/base_component.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class BaseComponent < ViewComponent::Base
   def before_render
     render_assets unless rendered_assets?

diff --git a/app/components/block_link_component.rb b/app/components/block_link_component.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class BlockLinkComponent < BaseComponent
   attr_reader :url, :action, :new_tab, :tag_options, :component
 

diff --git a/app/components/button_component.rb b/app/components/button_component.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class ButtonComponent < BaseComponent
   attr_reader :action, :icon, :big, :wide, :full_width, :outline, :unstyled, :danger, :tag_options
 

diff --git a/app/components/captcha_submit_button_component.rb b/app/components/captcha_submit_button_component.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class CaptchaSubmitButtonComponent < BaseComponent
   attr_reader :form, :action, :tag_options
 

diff --git a/app/components/click_observer_component.rb b/app/components/click_observer_component.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class ClickObserverComponent < BaseComponent
   attr_reader :event_name, :tag_options
 

diff --git a/app/components/clipboard_button_component.rb b/app/components/clipboard_button_component.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class ClipboardButtonComponent < BaseComponent
   attr_reader :clipboard_text, :button_options
 

diff --git a/app/components/countdown_alert_component.rb b/app/components/countdown_alert_component.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class CountdownAlertComponent < BaseComponent
   attr_reader :show_at_remaining, :alert_options, :countdown_options, :redirect_url, :tag_options
 

diff --git a/app/components/countdown_component.rb b/app/components/countdown_component.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class CountdownComponent < BaseComponent
   attr_reader :expiration, :update_interval, :start_immediately, :tag_options
 

diff --git a/app/components/download_button_component.rb b/app/components/download_button_component.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class DownloadButtonComponent < ButtonComponent
   attr_reader :file_data, :file_name, :tag_options
 

diff --git a/app/components/flash_component.rb b/app/components/flash_component.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class FlashComponent < BaseComponent
   VALID_FLASH_TYPES = %w[error info success warning other notice alert].freeze
 

diff --git a/app/components/form_link_component.rb b/app/components/form_link_component.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class FormLinkComponent < BaseComponent
   attr_reader :tag_options
 

diff --git a/app/components/icon_component.rb b/app/components/icon_component.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class IconComponent < BaseComponent
   # See: https://github.com/uswds/uswds/tree/develop/src/img/usa-icons
   ICONS = %i[

diff --git a/app/components/icon_list_component.rb b/app/components/icon_list_component.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class IconListComponent < BaseComponent
   renders_many :items, ->(**kwargs, &block) do
     IconListItemComponent.new(icon:, color:, **kwargs, &block)

diff --git a/app/components/javascript_required_component.rb b/app/components/javascript_required_component.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class JavascriptRequiredComponent < BaseComponent
   include LinkHelper
 

diff --git a/app/components/login_button_component.rb b/app/components/login_button_component.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class LoginButtonComponent < BaseComponent
   VALID_COLORS = ['primary', 'primary-darker', 'primary-lighter'].freeze
 

diff --git a/app/components/manageable_authenticator_component.rb b/app/components/manageable_authenticator_component.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class ManageableAuthenticatorComponent < BaseComponent
   attr_reader :configuration,
               :user_session,

diff --git a/app/components/memorable_date_component.rb b/app/components/memorable_date_component.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 ##
 # Provides a component that accepts a date using the inputs specified
 # by USWDS here: https://designsystem.digital.gov/components/memorable-date/

diff --git a/app/components/modal_component.rb b/app/components/modal_component.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class ModalComponent < BaseComponent
   attr_reader :tag_options
 

diff --git a/app/components/one_time_code_input_component.rb b/app/components/one_time_code_input_component.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class OneTimeCodeInputComponent < BaseComponent
   attr_reader :form,
               :name,

diff --git a/app/components/page_footer_component.rb b/app/components/page_footer_component.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class PageFooterComponent < BaseComponent
   attr_reader :tag_options
 

diff --git a/app/components/page_heading_component.rb b/app/components/page_heading_component.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class PageHeadingComponent < BaseComponent
   attr_reader :tag_options
 

diff --git a/app/components/password_confirmation_component.rb b/app/components/password_confirmation_component.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class PasswordConfirmationComponent < BaseComponent
   attr_reader :form, :field_options, :forbidden_passwords, :tag_options
 

diff --git a/app/components/password_strength_component.rb b/app/components/password_strength_component.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class PasswordStrengthComponent < BaseComponent
   attr_reader :input_id, :forbidden_passwords, :minimum_length, :tag_options
 

diff --git a/app/components/password_toggle_component.rb b/app/components/password_toggle_component.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class PasswordToggleComponent < BaseComponent
   attr_reader :form, :field_options, :tag_options
 

diff --git a/app/components/phone_input_component.rb b/app/components/phone_input_component.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class PhoneInputComponent < BaseComponent
   attr_reader :form,
               :confirmed_phone,

diff --git a/app/components/print_button_component.rb b/app/components/print_button_component.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class PrintButtonComponent < ButtonComponent
   attr_reader :tag_options
 

diff --git a/app/components/process_list_component.rb b/app/components/process_list_component.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class ProcessListComponent < BaseComponent
   renders_many :items, ->(**kwargs, &block) do
     ProcessListItemComponent.new(heading_level:, **kwargs, &block)

diff --git a/app/components/spinner_button_component.rb b/app/components/spinner_button_component.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class SpinnerButtonComponent < BaseComponent
   DEFAULT_LONG_WAIT_DURATION = 15.seconds
 

diff --git a/app/components/status_page_component.rb b/app/components/status_page_component.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class StatusPageComponent < BaseComponent
   ICONS = {
     info: [:question],

diff --git a/app/components/step_indicator_component.rb b/app/components/step_indicator_component.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class StepIndicatorComponent < BaseComponent
   attr_reader :current_step, :locale_scope, :tag_options
 

diff --git a/app/components/step_indicator_step_component.rb b/app/components/step_indicator_step_component.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class StepIndicatorStepComponent < BaseComponent
   attr_reader :title, :status, :tag_options
 

diff --git a/app/components/submit_button_component.rb b/app/components/submit_button_component.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class SubmitButtonComponent < ButtonComponent
   def initialize(big: true, wide: true, **tag_options)
     super(big:, wide:, **tag_options)

diff --git a/app/components/tab_navigation_component.rb b/app/components/tab_navigation_component.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class TabNavigationComponent < BaseComponent
   attr_reader :label, :routes, :tag_options
 

diff --git a/app/components/tag_component.rb b/app/components/tag_component.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class TagComponent < BaseComponent
   attr_reader :big, :informative, :tag_options
   alias_method :big?, :big

diff --git a/app/components/time_component.rb b/app/components/time_component.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class TimeComponent < BaseComponent
   attr_reader :time, :tag_options
 

diff --git a/app/components/troubleshooting_options_component.rb b/app/components/troubleshooting_options_component.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class TroubleshootingOptionsComponent < BaseComponent
   renders_one :header, 'TroubleshootingOptionsHeadingComponent'
   renders_many :options, BlockLinkComponent

diff --git a/app/components/validated_field_component.rb b/app/components/validated_field_component.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class ValidatedFieldComponent < BaseComponent
   attr_reader :form, :name, :tag_options, :input_type
 

diff --git a/app/components/vendor_outage_alert_component.rb b/app/components/vendor_outage_alert_component.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class VendorOutageAlertComponent < BaseComponent
   include LinkHelper
 

diff --git a/app/components/webauthn_input_component.rb b/app/components/webauthn_input_component.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class WebauthnInputComponent < BaseComponent
   attr_reader :platform, :passkey_supported_only, :show_unsupported_passkey, :tag_options
 

diff --git a/app/components/webauthn_verify_button_component.rb b/app/components/webauthn_verify_button_component.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class WebauthnVerifyButtonComponent < BaseComponent
   attr_reader :credentials, :user_challenge, :tag_options
 

diff --git a/app/controllers/account_reset/cancel_controller.rb b/app/controllers/account_reset/cancel_controller.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module AccountReset
   class CancelController < ApplicationController
     def show

diff --git a/app/controllers/account_reset/confirm_delete_account_controller.rb b/app/controllers/account_reset/confirm_delete_account_controller.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module AccountReset
   class ConfirmDeleteAccountController < ApplicationController
     def show

diff --git a/app/controllers/account_reset/confirm_request_controller.rb b/app/controllers/account_reset/confirm_request_controller.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module AccountReset
   class ConfirmRequestController < ApplicationController
     def show

diff --git a/app/controllers/account_reset/delete_account_controller.rb b/app/controllers/account_reset/delete_account_controller.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module AccountReset
   class DeleteAccountController < ApplicationController
     def show

diff --git a/app/controllers/account_reset/pending_controller.rb b/app/controllers/account_reset/pending_controller.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module AccountReset
   class PendingController < ApplicationController
     include UserAuthenticator

diff --git a/app/controllers/account_reset/recovery_options_controller.rb b/app/controllers/account_reset/recovery_options_controller.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module AccountReset
   class RecoveryOptionsController < ApplicationController
     include TwoFactorAuthenticatable

diff --git a/app/controllers/account_reset/request_controller.rb b/app/controllers/account_reset/request_controller.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module AccountReset
   class RequestController < ApplicationController
     include TwoFactorAuthenticatable

diff --git a/app/controllers/accounts/connected_accounts_controller.rb b/app/controllers/accounts/connected_accounts_controller.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Accounts
   class ConnectedAccountsController < ApplicationController
     include RememberDeviceConcern

diff --git a/app/controllers/accounts/history_controller.rb b/app/controllers/accounts/history_controller.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Accounts
   class HistoryController < ApplicationController
     include RememberDeviceConcern

diff --git a/app/controllers/accounts/personal_keys_controller.rb b/app/controllers/accounts/personal_keys_controller.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Accounts
   # Lets users generate a new personal key
   class PersonalKeysController < ApplicationController

diff --git a/app/controllers/accounts/two_factor_authentication_controller.rb b/app/controllers/accounts/two_factor_authentication_controller.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Accounts
   class TwoFactorAuthenticationController < ApplicationController
     include RememberDeviceConcern

diff --git a/app/controllers/accounts_controller.rb b/app/controllers/accounts_controller.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class AccountsController < ApplicationController
   include RememberDeviceConcern
   before_action :confirm_two_factor_authenticated

diff --git a/app/controllers/analytics_events_controller.rb b/app/controllers/analytics_events_controller.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Serve a static file from Rails so that the CORS middleware can add the correct headers
 class AnalyticsEventsController < ApplicationController
   prepend_before_action :skip_session_load

diff --git a/app/controllers/api/internal/sessions_controller.rb b/app/controllers/api/internal/sessions_controller.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Api
   module Internal
     class SessionsController < ApplicationController

diff --git a/app/controllers/api/internal/two_factor_authentication/auth_app_controller.rb b/app/controllers/api/internal/two_factor_authentication/auth_app_controller.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Api
   module Internal
     module TwoFactorAuthentication

diff --git a/app/controllers/api/internal/two_factor_authentication/piv_cac_controller.rb b/app/controllers/api/internal/two_factor_authentication/piv_cac_controller.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Api
   module Internal
     module TwoFactorAuthentication

diff --git a/app/controllers/api/internal/two_factor_authentication/webauthn_controller.rb b/app/controllers/api/internal/two_factor_authentication/webauthn_controller.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Api
   module Internal
     module TwoFactorAuthentication