Refactor component values into constant#10336
Merged
mitchellhenke merged 1 commit intomainfrom Mar 29, 2024
Merged
Conversation
zachmargolis
approved these changes
Mar 28, 2024
mitchellhenke
force-pushed
the
mitchellhenke/refactor-component-values
branch
from
92eea6a to
d60ae0f
Compare
changelog: Internal, Performance, Refactor component values into constant Co-authored-by: Zach Margolis <zachary.margolis@gsa.gov>
mitchellhenke
force-pushed
the
mitchellhenke/refactor-component-values
branch
from
d60ae0f to
a7f551d
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
To get closer to being thread-safer, this PR refactors the VoT component values out of a class instance variable into a constant. This value is only written once with what should be the same value, so the current implementation is probably safe, but this is more of moving to best practices around thread-safety.