Merged
Conversation
Provide a general-purpose method for displaying an event mismatch with an attribute diff.
Distinguish strings from symbols
Apparently these class matchers have additional flexibility.
Enables stuff like expect(analytics).to have_logged_event(:whatever).thrice
Try and say 'include()' or 'hash_including()' in failure messages
zachmargolis
approved these changes
Mar 28, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
This PR:
have_logged_eventRSpec matcher out to a class-based matcher implementingMatcherProtocolrather than using RSpec custom matcher DSLCountExpectationto support things likehave_logged_event(:foo).thricehave_logged_eventreportsAt some point, I'd like to switch
have_logged_eventover to use.exactly(:once)as the default, but that is not included in this PR (I believe there are a few specs that this would break).