LG-12729 Please Call page shows for passed IPP enrollments only#10333
LG-12729 Please Call page shows for passed IPP enrollments only#10333JackRyan1989 merged 5 commits intomainfrom
Conversation
…9-please-call-shows-for-ipp-passed-only Merging in main to resolve launch issues.
…creen when they fail ipp with fraud review pending
| return idv_verify_by_mail_enter_code_url if current_user.gpo_verification_pending_profile? | ||
| return idv_in_person_ready_to_verify_url if current_user.in_person_pending_profile? | ||
| # We don't want to hit idv_please_call_url in cases where the user | ||
| # has fraud review pending and not passed at the post office |
There was a problem hiding this comment.
nit: Can we be more specific with "fraud review pending"? I was thinking something like tmx fraud review pending ( or txm fraud review in review or)
Ignore this comment. I mixed up which fraud review- this is our internal. I think this is fine.
n1zyy
left a comment
There was a problem hiding this comment.
I still need to complete manual testing here, but :chef-kiss: (why is that still not an emoji here?) to this code. This PR makes it look simple, which I know from experience it isn't.
|
For test two, initially I observed that I was able to restart the IPP flow going from the account page. I did encounter the "Give us a call" before I reached the barcode page even though I picked pass for TMX on the SSN page. I hit refresh and did not sign out of the application. Jack confirmed this behavior does not exist if you sign out and then back in- just was you would because you would visit the PO. |
🎫 Ticket
Link to the relevant ticket:
LG-12729
🛠 Summary of changes
verify_profile_concernfor cases where the user has failed IPP and has fraud_review_pending on their profile📜 Testing Plan
Complete local testing for Threatmetrix for a passed enrollment:
Complete local testing for Threatmetrix for a failed enrollment: