Skip to content

LG-12729 Please Call page shows for passed IPP enrollments only#10333

Merged
JackRyan1989 merged 5 commits intomainfrom
jryan/lg-12729-please-call-shows-for-ipp-passed-only
Apr 1, 2024
Merged

LG-12729 Please Call page shows for passed IPP enrollments only#10333
JackRyan1989 merged 5 commits intomainfrom
jryan/lg-12729-please-call-shows-for-ipp-passed-only

Conversation

@JackRyan1989
Copy link
Contributor

@JackRyan1989 JackRyan1989 commented Mar 28, 2024

🎫 Ticket

Link to the relevant ticket:
LG-12729

🛠 Summary of changes

  • Added new redirect in verify_profile_concern for cases where the user has failed IPP and has fraud_review_pending on their profile
  • Added a new method on the user model to condense some repeated methods
  • Uncommented and passed specs from LG-12067

📜 Testing Plan

Complete local testing for Threatmetrix for a passed enrollment:

  • Complete an enrollment with fraud status set to 'review' via the drop down on the SSN page
  • In the rails console:
  • Grab the enrollment: e = InPersonEnrollment.where(enrollment_code: <enrollment_code>).first
  • Mock a passed response: json = UspsInPersonProofing::Mock::Fixtures.request_passed_proofing_results_response
  • Parse it: res = JSON.parse(json)
  • Create a new job instance: job = GetUspsProofingResultsJob.new
  • Stop the job from failing: job.instance_variable_set('@enrollment_outcomes', { enrollments_passed: 0 })
  • Send it: job.send(:process_enrollment_response, e, res)
  • Update your cache: e.reload
  • Log back in and confirm you see the Please Call screen

Complete local testing for Threatmetrix for a failed enrollment:

  • Complete an enrollment with fraud status set to 'review' via the drop down on the SSN page
  • In the rails console:
  • Grab the enrollment: e = InPersonEnrollment.where(enrollment_code: <enrollment_code>).first
  • Mock a passed response: json = UspsInPersonProofing::Mock::Fixtures.request_failed_proofing_results_response
  • Parse it: res = JSON.parse(json)
  • Create a new job instance: job = GetUspsProofingResultsJob.new
  • Stop the job from failing: job.instance_variable_set('@enrollment_outcomes', { enrollments_failed: 0 })
  • Send it: job.send(:process_enrollment_response, e, res)
  • Update your cache: e.reload
  • Log back in and confirm you DO NOT see the Please Call screen.
  • You should be able to restart the IPP flow going from the account page.

@JackRyan1989 JackRyan1989 requested a review from a team March 28, 2024 17:48
@JackRyan1989 JackRyan1989 self-assigned this Mar 28, 2024
return idv_verify_by_mail_enter_code_url if current_user.gpo_verification_pending_profile?
return idv_in_person_ready_to_verify_url if current_user.in_person_pending_profile?
# We don't want to hit idv_please_call_url in cases where the user
# has fraud review pending and not passed at the post office
Copy link
Contributor

@gina-yamada gina-yamada Mar 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Can we be more specific with "fraud review pending"? I was thinking something like tmx fraud review pending ( or txm fraud review in review or)

Ignore this comment. I mixed up which fraud review- this is our internal. I think this is fine.

Copy link
Contributor

@n1zyy n1zyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still need to complete manual testing here, but :chef-kiss: (why is that still not an emoji here?) to this code. This PR makes it look simple, which I know from experience it isn't.

@gina-yamada
Copy link
Contributor

For test two, initially I observed that I was able to restart the IPP flow going from the account page. I did encounter the "Give us a call" before I reached the barcode page even though I picked pass for TMX on the SSN page. I hit refresh and did not sign out of the application. Jack confirmed this behavior does not exist if you sign out and then back in- just was you would because you would visit the PO.

@gina-yamada gina-yamada self-requested a review March 29, 2024 21:52
@JackRyan1989 JackRyan1989 merged commit 58e5a77 into main Apr 1, 2024
@JackRyan1989 JackRyan1989 deleted the jryan/lg-12729-please-call-shows-for-ipp-passed-only branch April 1, 2024 13:45
@aduth aduth mentioned this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants