LG-11803 Add Cancel button to the How to Verify Page#10330
Conversation
…o the how to verify view that is currently turned off
gina-yamada
requested review from
a team,
rutvigupta-design and
svalexander
and removed request for
a team
| end | ||
|
|
||
| context 'renders the show template with' do | ||
| it 'a title and info text' do |
There was a problem hiding this comment.
nit - can we change this to something like it 'has expected title and info text' so it reads more naturally?
There was a problem hiding this comment.
@svalexander Here is how it currently reads when you run the specs
Existing: renders the show template with a title and info text.
Your suggestion: renders the show template with has expected title and info text.
I initially had expected in each but thought about it being implicitly implied because there was a test for it. I am willing to change it but wondering with this extra information if you'd still like to see that change.
There was a problem hiding this comment.
oh lol yes you're right, ignore my comments about updating language
| expect(rendered).to have_content(t('doc_auth.info.how_to_verify')) | ||
| end | ||
|
|
||
| it 'two options for verifying your identity' do |
There was a problem hiding this comment.
this is similar enough to the above test that I don't think it's needed
| expect(rendered).to have_content(t('doc_auth.headings.verify_at_post_office')) | ||
| end | ||
|
|
||
| it 'a continue button' do |
There was a problem hiding this comment.
nit - can we change this to something like 'it 'has a continue button'?
There was a problem hiding this comment.
similar thought for the other 2 tests that proceed this
There was a problem hiding this comment.
Ignore this comment based on the screenshot you provided above
|
works as expected when manually testing, just a few small nits around the spec file |
carmenrosalop
requested review from
carmenrosalop
and removed request for
rutvigupta-design
…03-Add-Cancel-To-How-To-Verify-View
gina-yamada
deleted the
yamada/LG-11803-Add-Cancel-To-How-To-Verify-View
branch
3 participants
🎫 Ticket
LG-11803 Add 'Cancel' button to the "How To Verify" page
🛠 Summary of changes
📜 Testing Plan
in_person_proofing_opt_in_enabled: trueandin_person_proofing_enabled: true🎥 A Short Film
cancel.button.on.how.to.verify.mov
📷 Screenshot
Spanish and French Translations of Cancel Link