Split separate verify-by-mail enter-code contexts into partials#10327
Merged
Split separate verify-by-mail enter-code contexts into partials#10327
Conversation
The `Idv::ByMail::EnterCodeController` is responsible for rendering a screen where the user can enter their code. It renders a form for the user to enter a code in 2 contexts: 1. When the user signs in with a pending GPO profile 2. When the user clicks on the “sign in to request another letter” link on the “Finish verifying your identity” reminder email These contexts are conveyed to the view using the `@user_did_not_receive_letter` and several changes are made accordingly. In [LG-11753](https://cm-jira.usa.gov/browse/LG-11753) and [LG-12064](https://cm-jira.usa.gov/browse/LG-12064) we are making dramatic changes to these screens. Both contexts look very different so this commit breaks them into partials so they can be done independently. There is some shared code that is moved into the partials that can be moved out when this work is finished. Namely the alert that a user cannot send more letters and the “Return to your profile” link on the bottom of the page. I have opted to move everything into the partials so we can modify the screens separately and then break out shared content in a follow up. [skip changelog]
matthinz
approved these changes
Mar 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Idv::ByMail::EnterCodeControlleris responsible for rendering a screen where the user can enter their code. It renders a form for the user to enter a code in 2 contexts:These contexts are conveyed to the view using the
@user_did_not_receive_letterand several changes are made accordingly.In LG-11753 and LG-12064 we are making dramatic changes to these screens. Both contexts look very different so this commit breaks them into partials so they can be done independently.
There is some shared code that is moved into the partials that can be moved out when this work is finished. Namely the alert that a user cannot send more letters and the “Return to your profile” link on the bottom of the page. I have opted to move everything into the partials so we can modify the screens separately and then break out shared content in a follow up.