Revert "Ensure that the pids directory is present for puma"#10322
Merged
mitchellhenke merged 1 commit intomainfrom Mar 27, 2024
Merged
Revert "Ensure that the pids directory is present for puma"#10322mitchellhenke merged 1 commit intomainfrom
mitchellhenke merged 1 commit intomainfrom
Conversation
This reverts commit f47a26f.
Contributor
|
I added that PR because without it, I get the failure: as the directory This is also discussed in https://stackoverflow.com/questions/52862529/no-such-file-or-directory-rb-sysopen-tmp-pids-puma-pid. |
Contributor
|
We could use the one of the other solutions mentioned - https://stackoverflow.com/a/70313875. |
aduth
approved these changes
Mar 27, 2024
Contributor
aduth
left a comment
There was a problem hiding this comment.
Approving to fix deployed environments, but also think the alternative @vrajmohan mentioned sounds interesting, assuming it doesn't similarly cause issues for deployed environments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #10308
This is causing issues in deployed environments due to some weird things we do around symbolic links, so I'm reverting this until we can fix that.