Skip to content

Revert "Ensure that the pids directory is present for puma"#10322

Merged
mitchellhenke merged 1 commit intomainfrom
revert-10308-keep-tmp-pids-directory
Mar 27, 2024
Merged

Revert "Ensure that the pids directory is present for puma"#10322
mitchellhenke merged 1 commit intomainfrom
revert-10308-keep-tmp-pids-directory

Conversation

@mitchellhenke
Copy link
Contributor

Reverts #10308

This is causing issues in deployed environments due to some weird things we do around symbolic links, so I'm reverting this until we can fix that.

@mitchellhenke mitchellhenke requested a review from vrajmohan March 26, 2024 23:45
@vrajmohan
Copy link
Contributor

I added that PR because without it, I get the failure:

21:42:19 web.1    | /Users/radhakrishnanvrajmoh/.rbenv/versions/3.3.0/lib/ruby/gems/3.3.0/gems/puma-6.4.2/lib/puma/launcher.rb:312:in `write': No such file or directory @ rb_sysopen - tmp/pids/server.pid (Errno::ENOENT)

as the directory tmp/pids does not exist on a fresh clone of the repo.

This is also discussed in https://stackoverflow.com/questions/52862529/no-such-file-or-directory-rb-sysopen-tmp-pids-puma-pid.

@vrajmohan
Copy link
Contributor

We could use the one of the other solutions mentioned - https://stackoverflow.com/a/70313875.

Copy link
Contributor

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to fix deployed environments, but also think the alternative @vrajmohan mentioned sounds interesting, assuming it doesn't similarly cause issues for deployed environments.

@mitchellhenke mitchellhenke merged commit c08b76e into main Mar 27, 2024
@mitchellhenke mitchellhenke deleted the revert-10308-keep-tmp-pids-directory branch March 27, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants