LG-12268: Fix bug in face match failure result copy#10321
Merged
eileen-nava merged 2 commits intomainfrom Mar 27, 2024
Merged
Conversation
night-jellyfish
force-pushed
the
em/repro-face-match-error
branch
from
ca27b28 to
9faa9ab
Compare
eileen-nava
requested review from
a team,
amirbey,
charleyf,
dawei-nava,
kellular and
night-jellyfish
and removed request for
a team
charleyf
approved these changes
Mar 27, 2024
Contributor
charleyf
left a comment
charleyf
left a comment
There was a problem hiding this comment.
I verified this in test using yaml files and it looks correct to me.
Facematch fail
Liveness Fail
Document Fail
amirbey
requested changes
Mar 27, 2024
Contributor
amirbey
left a comment
amirbey
left a comment
There was a problem hiding this comment.
Blocking - testing spanish
amirbey
approved these changes
Mar 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
LG-12268
🛠 Summary of changes
📜 Testing Plan
Provide a checklist of steps to confirm the changes.
spec/fixtures/ial2_test_portrait_match_failure.ymlfor the front, back, and selfie image👀 Screenshots
I know the bug we found wasn't affecting inline error messages, but I am including a screenshot of inline error messages for thoroughness's sake.
English errors (body copy):
English errors (inline errors):
Spanish errors (body copy):
Spanish errors (inline errors):
French errors (body copy):
French errors (inline errors):