Always initialize geocoder if geolocation data file exists#10319
Merged
Conversation
changelog: Internal, Geocoder, Initialize geocoder in local development if data file present
aduth
changed the title
Contributor
Author
|
We could keep the production check for the eager initialization here, if it helps avoid long start times in local development 🤷 |
| GEO_DATA_FILEPATH = Rails.root.join(IdentityConfig.store.geo_data_file_path).freeze | ||
|
|
||
| if Rails.env.production? && File.exist?(GEO_DATA_FILEPATH) | ||
| if File.exist?(GEO_DATA_FILEPATH) |
Contributor
There was a problem hiding this comment.
this is probably better served by a feature flag if we do want it to be configurable.
mitchellhenke
approved these changes
Mar 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Updates geocoder initializer to always load the geocoder file if it exists, regardless of environment.
This is to avoid future confusion like I experienced when following our instructions to set up geolocation and it not working as instructed.
📜 Testing Plan
rails cGeocoder.search(Faker::Internet.ip_v4_address).first