Update IdvController spec to use have_logged_event#10316
Merged
Conversation
theabrad
approved these changes
Mar 26, 2024
…_extra_analytics: [:*] [skip changelog]
matthinz
force-pushed
the
matthinz/idv-controller-analytics
branch
2 times, most recently
from
2cd3c02 to
d602f43
Compare
Contributor
Author
|
It seemed like the |
zachmargolis
approved these changes
Mar 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously: #10258, #10309
This PR:
IdvControllerto usehave_logged_eventand removesallowed_extra_analytics