Skip to content

LG-12294: Send aggregated email notification for new device sign-in#10314

Merged
aduth merged 18 commits intomainfrom
aduth-lg-12294-new-device-attempt-email
Apr 4, 2024
Merged

LG-12294: Send aggregated email notification for new device sign-in#10314
aduth merged 18 commits intomainfrom
aduth-lg-12294-new-device-attempt-email

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented Mar 26, 2024

🎫 Ticket

LG-12294

🛠 Summary of changes

Adds a new email template for revised new-device sign-in notifications.

📜 Testing Plan

  1. Go to:
    1. Sign in before 2FA: http://localhost:3000/rails/mailers/user_mailer/new_device_sign_in_before_2fa
    2. Sign in before 2FA with multiple attempts: http://localhost:3000/rails/mailers/user_mailer/new_device_sign_in_before_2fa?failed_times=2
    3. Sign in after 2FA: http://localhost:3000/rails/mailers/user_mailer/new_device_sign_in_after_2fa
  2. Review content

👀 Screenshots

Before MFA After MFA
image image

@aduth aduth force-pushed the aduth-lg-12294-new-device-attempt-email branch from b6dfdc1 to 58fb51b Compare March 28, 2024 19:58
aduth added 8 commits April 3, 2024 08:55
Original change was trying to resolve Sass error, fixed by reinstalling dependencies. Importing uswds-core ensures other overrides defined in stylesheets/_uswds-core.scss are applied
@aduth aduth marked this pull request as ready for review April 3, 2024 15:55
@aduth aduth requested a review from a team April 3, 2024 15:55
Copy link
Contributor

@jmdembe jmdembe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏾

@aduth aduth merged commit 0b2842d into main Apr 4, 2024
@aduth aduth deleted the aduth-lg-12294-new-device-attempt-email branch April 4, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants