Conversation
page In #10280 we reworded the `secure_account` step to "Re-enter your password" so it no longer makes sense to have the final step be current once the user has re-entered their password. The PR adds a new current_step of `ALL_STEPS_COMPLETED` which can be used to force all steps to render as completed. changelog: User-Facing Improvements, Identity verification, On personal key screen the step indicator shows all steps complete.
Co-authored-by: Andrew Duthie <1779930+aduth@users.noreply.github.com>
solipet
deleted the
dprice-lg-12061-step-indicator-on-personal-key-screen
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
LG-12061
🛠 Summary of changes
In #10280 we reworded the
secure_accountstep to "Re-enter your password" so it no longer makes sense to have the final step be current once the user has re-entered their password.The PR adds a new current_step of
ALL_STEPS_COMPLETEDwhich can be used to force all steps to render as completed.👀 Screenshots
Before:
After: