Merged
Conversation
changelog: Internal, Doc Auth, Log image file name.
dawei-nava
changed the title
aduth
reviewed
Mar 25, 2024
eileen-nava
reviewed
Mar 25, 2024
Contributor
eileen-nava
left a comment
eileen-nava
left a comment
There was a problem hiding this comment.
I manually tested this while running make watch_events and file names were logged as expected. I am not sure what's going on with the string interpolation in api_image_upload_form_spec.rb and think that spec needs to be revisited before we merge this code.
eileen-nava
approved these changes
Mar 26, 2024
Contributor
eileen-nava
left a comment
eileen-nava
left a comment
There was a problem hiding this comment.
This looks good, thanks for revisiting the spec file. 👍🏻
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
LG-12280
🛠 Summary of changes
Send doc auth image file name as part of metadata, so it can be logged.
📜 Testing Plan
Provide a checklist of steps to confirm the changes.