Don't use stale document capture user ids for effective_user#10293
Merged
Don't use stale document capture user ids for effective_user#10293
Conversation
If the user deletes their account, it is possible that the user id stored in the session for document capture will not be valid. This results in analytics events being improperly attributed to `anonymous-uuid`. changelog: Bug Fixes, Identity verification, Fix log attribute issue associated with hybrid handoff. Co-authored-by: Doug Price <douglas.price@gsa.gov>
zachmargolis
approved these changes
Mar 22, 2024
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
aduth
reviewed
Mar 25, 2024
| user = User.find_by(id: effective_user_id) if effective_user_id | ||
|
|
||
| if user.nil? | ||
| session.delete(:doc_capture_user_id) |
Contributor
There was a problem hiding this comment.
I find it a little strange we delete this after-the-fact, and as a side-effect of a getter method.
Should we delete this at the time that it becomes invalid? As in your pull request comment: "If the user deletes their account".
Contributor
Author
There was a problem hiding this comment.
Yeah, we considered that at first. But I think keeping it here means that things are slightly less "spread out" and easier to keep track of. Hopefully it will be academic because I am trying to get a ticket to remove effective_user refined and on Team Ada's plate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
LG-12793
🛠 Summary of changes
If the user deletes their account, it is possible that the user id stored in the session for document capture will not be valid. This results in analytics events being improperly attributed to
anonymous-uuid.