Offload styles from main application stylesheet#10285
Merged
Conversation
changelog: Internal, Performance, Reduce size of common application stylesheet
This reverts commit 9275e2e.
After reverting modal changes, will address separately
zachmargolis
approved these changes
Mar 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Removes several items from the main application stylesheet to reduce its size:
usa-step-indicatorstylesusa-collectionstyles to document capture as the only place it's usedPerformance Impact:
NODE_ENV=production yarn build:css && brotli-size app/assets/builds/application.cssBefore: 22.7 kB
After: 21.6 kB
Diff: -1.1 kB (-4.8%)
📜 Testing Plan
Verify no regressions in affected styles, particularly account page header and navigation, and address search functionality for in-person proofing during document capture.