Skip to content

LG-12609 piv interstitial method#10282

Merged
mdiarra3 merged 41 commits intomainfrom
LG-12609-piv-interstitial-method
Apr 9, 2024
Merged

LG-12609 piv interstitial method#10282
mdiarra3 merged 41 commits intomainfrom
LG-12609-piv-interstitial-method

Conversation

@mdiarra3
Copy link
Contributor

@mdiarra3 mdiarra3 commented Mar 21, 2024

🎫 Ticket

Link to the relevant ticket:
LG-12609

🛠 Summary of changes

This adds an interstiatial page that takes into account when users use a .gov or .mil account and prompts them to add a PIV card if it comes from PIV/CAC cards.

📜 Testing Plan

Provide a checklist of steps to confirm the changes.

  • Test Account Creation flow
  1. Create account with email as .gov
  2. User is prompted to add PIV Cac as MFA before selecting MFA
  3. User can Add Piv and then directed to Second MFA reminder
  4. User can skip and be redirected to MFA selection screen
  • Account Sign in flow
  1. User with a .gov account (Can do this by having a regular account and then adding a .gov account to their email).
  2. User is prompted to enter existing MFA
  3. AFter successful full sign in they are prompted to set up PIV Cac as authentication method
  4. User can skip and go forward, or can add a PIV and be redirected to final sight.

New User interstitial
Screenshot 2024-03-26 at 2 09 25 PM

Existing User interstitial
Screenshot 2024-03-26 at 2 12 25 PM

@mdiarra3 mdiarra3 marked this pull request as ready for review March 26, 2024 18:12
@mdiarra3 mdiarra3 requested a review from a team March 26, 2024 18:24
@mdiarra3
Copy link
Contributor Author

mdiarra3 commented Mar 26, 2024

Needs #10315 to be merged and rebased before we can merge this

@mdiarra3 mdiarra3 requested review from a team and aduth April 2, 2024 15:56
@mdiarra3 mdiarra3 requested a review from aduth April 4, 2024 18:22
Copy link
Contributor

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Few minor comments, but tested well for me locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants