Merged
Conversation
aduth
reviewed
Mar 22, 2024
aduth
reviewed
Mar 25, 2024
Contributor
Author
|
Needs #10315 to be merged and rebased before we can merge this |
aduth
reviewed
Mar 26, 2024
aduth
reviewed
Mar 26, 2024
app/controllers/users/two_factor_authentication_setup_controller.rb
Outdated
Show resolved
Hide resolved
…12609-piv-interstitial-method
aduth
reviewed
Apr 2, 2024
app/controllers/users/two_factor_authentication_setup_controller.rb
Outdated
Show resolved
Hide resolved
db/primary_migrate/20240326181600_add_piv_cac_recommended_dismissed_at_on_user.rb
Show resolved
Hide resolved
spec/controllers/users/two_factor_authentication_setup_controller_spec.rb
Show resolved
Hide resolved
aduth
reviewed
Apr 4, 2024
aduth
approved these changes
Apr 5, 2024
Contributor
aduth
left a comment
There was a problem hiding this comment.
LGTM 👍 Few minor comments, but tested well for me locally
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
LG-12609
🛠 Summary of changes
This adds an interstiatial page that takes into account when users use a .gov or .mil account and prompts them to add a PIV card if it comes from PIV/CAC cards.
📜 Testing Plan
Provide a checklist of steps to confirm the changes.
New User interstitial

Existing User interstitial
