Remove nonstandard and redundant icons for government banner#10275
Remove nonstandard and redundant icons for government banner#10275
Conversation
changelog: Bug Fixes, Layout, Use design system asset for government banner lock icon
|
Edit: Implemented in f44d2fd and updated pull request content to reflect. |
|
The color on the lock icon changed slightly, is it supposed to match the text it's in? Or be a specific color? |
Technically it's supposed to match the text around it, if we were using the documented inline SVG styles. We don't follow this guidance and instead reference the image externally, as an optimization for collapsed content. But the actual color change was mentioned in the pull request and even though it's still static and doesn't strictly follow the surrounding content, I think in practice the updated color is more aligned to the surrounding content.
|
For what it's worth, I would like to move toward reconciliation here, but it's something I'd propose to USWDS and we can take advantage of if/when it comes down to us. |
See upstream: uswds/uswds#5829 |
🛠 Summary of changes
Removes icon assets to allow design system standard to be used instead:
lock.svgto allow the design system standardlock.svgicon-dot-gov.svgto allow the design system standardicon-dot-gov.svgicon-https.svgto allow the design system standardicon-https.svgVisually, they are identical, but the custom lock icon we implemented previously was slightly lighter, which notably stood out more from the surrounding content (see screenshots below).
📜 Testing Plan
👀 Screenshots