Bug fix: Hide the selfie hint box when there's no text.#10274
Merged
Conversation
aduth
reviewed
Mar 21, 2024
app/javascript/packages/document-capture/components/acuant-selfie-capture-canvas.scss
Outdated
Show resolved
Hide resolved
aduth
approved these changes
Mar 21, 2024
app/javascript/packages/document-capture/components/acuant-selfie-capture-canvas.scss
Outdated
Show resolved
Hide resolved
app/javascript/packages/document-capture/components/acuant-selfie-capture-canvas.scss
Outdated
Show resolved
Hide resolved
app/javascript/packages/document-capture/components/acuant-selfie-capture-canvas.scss
Outdated
Show resolved
Hide resolved
eileen-nava
approved these changes
Mar 21, 2024
Contributor
eileen-nava
left a comment
eileen-nava
left a comment
There was a problem hiding this comment.
I manually tested and the selfie hint box no longer appears when there is no hint text. Approved.
app/javascript/packages/document-capture/components/acuant-selfie-capture-canvas.scss
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Slack thread bug report is here.
🛠 Summary of changes
This PR adds a few lines of CSS to hide an odd black dot that was appearing when the selfie hint text was empty. What was happening is that we style the
<p>element with the class.document-capture-selfie-feedback. But because that styling was always applied, we were essentially getting a black background<p>element with padding. This change hides the<p>using CSS when it has no text inside it.📜 Testing Plan
Provide a checklist of steps to confirm the changes.
👀 Screenshots
If relevant, include a screenshot or screen capture of the changes.
Before:
After with padding
After, no padding