Skip to content

LG-12618: log the sp request components for enhanced idv events.#10265

Merged
solipet merged 12 commits intomainfrom
dprice-lg-12618-include-sp-request-in-event-logs
Mar 21, 2024
Merged

LG-12618: log the sp request components for enhanced idv events.#10265
solipet merged 12 commits intomainfrom
dprice-lg-12618-include-sp-request-in-event-logs

Conversation

@solipet
Copy link
Contributor

@solipet solipet commented Mar 18, 2024

🎫 Ticket

Link to the relevant ticket:
LG-12618

🛠 Summary of changes

This change logs the resolved authn context in CloudWatch events under the key sp_request and provides a hash with the following keys, if they are true:

  • aal2
  • biometric_comparison
  • component_values - { 'value' => true, 'value2' => true }
  • hspd12
  • ialmax
  • identity_proofing
  • phishing_resistant

If there isn't a vtr or acr_values saved in the session, the sp_request will not be included at all.

solipet added 2 commits March 18, 2024 19:06
This change logs the resolved authn context in CloudWatch events under
the key `sp_request` and provides a hash with the following keys:

- `aal2?`
- `biometric_comparison?`
- `component_values`
    - array of hash: `{name:, description:}`
- `hspd12?`
- `ialmax?`
- `identity_proofing?`
- `phishing_resistant?`

changelog: Internal, Logging, Includes the authn context in IdV events
@solipet solipet force-pushed the dprice-lg-12618-include-sp-request-in-event-logs branch from 8752f48 to e584604 Compare March 19, 2024 17:20
solipet and others added 4 commits March 19, 2024 13:55
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
include them if they are true.

Also strips the trailing `?` off the keys.
solipet and others added 3 commits March 19, 2024 16:47
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
Co-authored-by: Zach Margolis <zachary.margolis@gsa.gov>
@solipet solipet marked this pull request as ready for review March 19, 2024 21:35
@solipet solipet requested review from a team, matthinz and zachmargolis March 19, 2024 21:35
@solipet solipet requested a review from zachmargolis March 21, 2024 15:17
Copy link
Contributor

@matthinz matthinz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@solipet solipet merged commit 4d4f708 into main Mar 21, 2024
@solipet solipet deleted the dprice-lg-12618-include-sp-request-in-event-logs branch March 21, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants