Skip to content

LG-12655: selfie hints are voiced when voice accessibility is enabled#10223

Merged
amirbey merged 2 commits intomainfrom
amirbey/LG-12655-selfie-hints-voice
Mar 12, 2024
Merged

LG-12655: selfie hints are voiced when voice accessibility is enabled#10223
amirbey merged 2 commits intomainfrom
amirbey/LG-12655-selfie-hints-voice

Conversation

@amirbey
Copy link
Contributor

@amirbey amirbey commented Mar 8, 2024

🎫 Ticket

LG-12655

🛠 Summary of changes

Allow selfie hints to be read out by screen reader.

📜 Testing Plan

  • Enable screen reader on browser
  • Attempt to capture a selfie using the SDK
  • Move your face around the screen and verify that the hints are voiced by the screen reader

@amirbey amirbey force-pushed the amirbey/LG-12655-selfie-hints-voice branch from 57f32b1 to a6c2492 Compare March 8, 2024 18:53
@amirbey amirbey self-assigned this Mar 8, 2024
@amirbey amirbey requested review from eileen-nava and kellular March 8, 2024 18:56
@amirbey amirbey requested a review from aduth March 8, 2024 18:57
@amirbey amirbey force-pushed the amirbey/LG-12655-selfie-hints-voice branch from e4f43e3 to 0d030de Compare March 11, 2024 19:28
Copy link
Contributor

@eileen-nava eileen-nava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this and it read the selfie hints. 👍🏻

@amirbey amirbey marked this pull request as ready for review March 12, 2024 15:10
Copy link
Contributor

@charleyf charleyf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this with this PR and it's a great improvement.

amirbey added 2 commits March 12, 2024 12:25
Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>

changelog: Upoming Features, Document Authentication, Selfie capture hints are voice accessible
@amirbey amirbey force-pushed the amirbey/LG-12655-selfie-hints-voice branch from 0d030de to 9978fcc Compare March 12, 2024 16:25
@amirbey amirbey merged commit 5117934 into main Mar 12, 2024
@amirbey amirbey deleted the amirbey/LG-12655-selfie-hints-voice branch March 12, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants