LG-12563 add vot to user info controller#10215
Merged
Conversation
jmhooper
reviewed
Mar 7, 2024
zachmargolis
reviewed
Mar 8, 2024
changelog: Upcoming features,VoT,Added Vot to oidc user info
jmax-gsa
force-pushed
the
jmax/LG-12563-add-vot-to-user-info-controller
branch
from
5bb9100 to
4be986d
Compare
zachmargolis
reviewed
Mar 8, 2024
Change `vtr:` parameter of `oidc_end_client_secret_jwt` to `vot:`, because that's what it is.
Removed redundant `.compact` Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
jmhooper
reviewed
Mar 8, 2024
Removed unnecessary wrapping/unwrapping of vtr, and also removed a potential headache for when we support multiple-vot requests.
jmhooper
approved these changes
Mar 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket: LG-12563
🛠 Summary of changes
Added code to
UserinfoControllerto report VoT information as part of the user info if and only if the SP asks for it.📜 Testing Plan
Provide a checklist of steps to confirm the changes.