Skip to content

LG-12557: portrait match is received when not requested#10193

Merged
amirbey merged 9 commits intomainfrom
amirbey/LG-12557-selfie-not-requested
Mar 11, 2024
Merged

LG-12557: portrait match is received when not requested#10193
amirbey merged 9 commits intomainfrom
amirbey/LG-12557-selfie-not-requested

Conversation

@amirbey
Copy link
Contributor

@amirbey amirbey commented Feb 29, 2024

[skip changelog]

🎫 Ticket

LG-12557

🛠 Summary of changes

  • TrueIDResponse only parse and store portrait match when a portrait match was requested
    • Restore use of :success in Document capture result

📜 Testing Plan

  • unit test coverage

@amirbey amirbey self-assigned this Feb 29, 2024
@amirbey amirbey force-pushed the amirbey/LG-12557-selfie-not-requested branch from 363e162 to ed66b4e Compare March 8, 2024 22:17
@amirbey amirbey marked this pull request as ready for review March 11, 2024 13:32
@amirbey amirbey changed the title LG-12557: bug fix when portrait match is received when not requested LG-12557: portrait match is received when not requested Mar 11, 2024
Copy link
Contributor

@dawei-nava dawei-nava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@amirbey amirbey force-pushed the amirbey/LG-12557-selfie-not-requested branch from acf10c4 to 58c4012 Compare March 11, 2024 19:00
@amirbey amirbey merged commit 5837343 into main Mar 11, 2024
@amirbey amirbey deleted the amirbey/LG-12557-selfie-not-requested branch March 11, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants