Conversation
mdiarra3
changed the title
|
I noticed another two references to the raw config values. Do these need to be updated? |
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
Any thoughts on findings identified in #10189 (comment) ?
Yup, I addressed |
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
Surfacing relevant comment out of old thread: #10189 (comment)
There was a problem hiding this comment.
We don't have test coverage for the scenario where IdentityConfig.store.account_reset_fraud_user_wait_period_days is nil (the default except in test environment). I think there's an error in this scenario.
|
|
||
| def fraud_wait_period_not_met?(arr) | ||
| if fraud_wait_period_days.present? | ||
| return arr.requested_at > (Time.zone.now - fraud_wait_period_days.days) |
There was a problem hiding this comment.
Related to previous comment, fraud_wait_period_days can be nil.
> nil.days
NoMethodError: undefined method `days' for nil
There was a problem hiding this comment.
thanks for catching! ill add spec for that
There was a problem hiding this comment.
Looks like it shouldnt occur since fraud_wait_period_days we check if its present. I added a couple nil specs to ensure that this isn't occurring anywhere.
2 participants
🎫 Ticket
Link to the relevant ticket:
LG-11784
🛠 Summary of changes
This will allow users that are currently in fraud review an extended time before they will be able to reset their account.
📜 Testing Plan
Users not in pending review should not see any change
Users in fraud review for Idv they should now see a longer time before they can receive their account deletion request fulfilled.