Skip to content

Block subdomains of disposable email domains from signup (LG-12589)#10181

Merged
zachmargolis merged 4 commits intomainfrom
margolis-block-disposable-subdomains
Feb 29, 2024
Merged

Block subdomains of disposable email domains from signup (LG-12589)#10181
zachmargolis merged 4 commits intomainfrom
margolis-block-disposable-subdomains

Conversation

@zachmargolis
Copy link
Contributor

🎫 Ticket

LG-12589

🛠 Summary of changes

Blocks subdomains of blocked domains. Please see JIRA ticket for additional details and context

changelog: Internal, Signup, Block subdomains of disposable email domains from signup
@zachmargolis zachmargolis requested review from a team February 28, 2024 22:26
Copy link
Contributor

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, LGTM

@zachmargolis zachmargolis merged commit bdae55b into main Feb 29, 2024
@zachmargolis zachmargolis deleted the margolis-block-disposable-subdomains branch February 29, 2024 19:18
jmdembe pushed a commit that referenced this pull request Feb 29, 2024
…10181)

* Update valid_email gem to use new "partial" option for disposable domain blocking

changelog: Internal, Signup, Block subdomains of disposable email domains from signup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants