Skip to content

Remove tid argument from OIDC auth helpers #10177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmhooper merged 2 commits into from
Feb 28, 2024
Merged

Remove tid argument from OIDC auth helpers #10177

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f550c2
Remove `tid` argument from OIDC auth helpers
jmhooper Feb 28, 2024
e83c4f2
syntax error
jmhooper Feb 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 15 additions & 17 deletions spec/support/oidc_auth_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,11 +62,12 @@ def visit_idp_from_ial1_oidc_sp_defaulting_to_aal3(**args)
oidc_path
end

def ial1_params(prompt: nil,
state: SecureRandom.hex,
nonce: SecureRandom.hex,
client_id: OIDC_IAL1_ISSUER,
tid: nil)
def ial1_params(
prompt: nil,
state: SecureRandom.hex,
nonce: SecureRandom.hex,
client_id: OIDC_IAL1_ISSUER
)
ial1_params = {
client_id: client_id,
response_type: 'code',
Expand All @@ -76,18 +77,18 @@ def ial1_params(prompt: nil,
state: state,
nonce: nonce,
}
ial1_params[:tid] = tid if tid
ial1_params[:prompt] = prompt if prompt
ial1_params
end

def ial2_params(prompt: nil,
state: SecureRandom.hex,
nonce: SecureRandom.hex,
client_id: OIDC_ISSUER,
acr_values: Saml::Idp::Constants::IAL2_AUTHN_CONTEXT_CLASSREF,
tid: nil,
biometric_comparison_required: false)
def ial2_params(
prompt: nil,
state: SecureRandom.hex,
nonce: SecureRandom.hex,
client_id: OIDC_ISSUER,
acr_values: Saml::Idp::Constants::IAL2_AUTHN_CONTEXT_CLASSREF,
biometric_comparison_required: false
)
ial2_params = {
client_id: client_id,
response_type: 'code',
Expand All @@ -97,7 +98,6 @@ def ial2_params(prompt: nil,
state: state,
nonce: nonce,
}
ial2_params[:tid] = tid if tid
ial2_params[:prompt] = prompt if prompt
if biometric_comparison_required
ial2_params[:biometric_comparison_required] = 'true'
Expand All @@ -111,8 +111,7 @@ def vtr_params(
state: SecureRandom.hex,
nonce: SecureRandom.hex,
client_id: OIDC_ISSUER,
scope: 'openid email profile:name social_security_number',
tid: nil
scope: 'openid email profile:name social_security_number'
)
vtr_params = {
client_id: client_id,
Expand All @@ -123,7 +122,6 @@ def vtr_params(
state: state,
nonce: nonce,
}
vtr_params[:tid] = tid if tid
vtr_params[:prompt] = prompt if prompt
vtr_params
end
Expand Down