Conversation
This commit adds a feature spec for an OIDC authentication using VTR. This spec makes a request for a proofed user with a VTR and validates everything works as expected including the identity token attributes and user info response. [skip changelog]
| state: state, | ||
| nonce: nonce, | ||
| } | ||
| vtr_params[:tid] = tid if tid |
Contributor
There was a problem hiding this comment.
what's tid? is that the ID we added for inherited proofing?
Contributor
There was a problem hiding this comment.
ooo nvm it was for attempts API, we can probably drop that here
Contributor
Author
There was a problem hiding this comment.
I am not sure. I copied this over from the other methods that setup OIDC params (ial1_params and ial2_params). It is entirely possible this is left over from inherited proofing. If so my preference would be to keep it consistent here and remove it in a follow-on PR.
Contributor
Author
There was a problem hiding this comment.
Here is a change to remove tid along with some explanation: #10177
zachmargolis
approved these changes
Feb 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a feature spec for an OIDC authentication using VTR. This spec makes a request for a proofed user with a VTR and validates everything works as expected including the identity token attributes and user info response.