Remove shared example from SamlIdpController tests#10174
Merged
Conversation
matthinz
approved these changes
Feb 28, 2024
The `SamlIdpController` tests had a shared example for what happens when a users signs in with an already verified account. This shared example is not actually shared between any examples. It is only used for the IAL2 case. This commit goes ahead and breaks it out into individual tests instead of using a shared example. [skip changelog]
jmhooper
force-pushed
the
jmhooper-saml-controller-shared-example
branch
from
ae40c96 to
eeede46
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
SamlIdpControllertests had a shared example for what happens when a users signs in with an already verified account. This shared example is not actually shared between any examples. It is only used for the IAL2 case. This commit goes ahead and breaks it out into individual tests instead of using a shared example.