Modify the ID token builder to recognize JSON encoded VTR params#10168
Merged
Modify the ID token builder to recognize JSON encoded VTR params#10168
Conversation
The `identities.vtr` column has one of the following values: 1. A JSON-encoded representation of the `vtr` param if the `vtr` param is consumed and used 2. Nil The `IdTokenBuilder` uses this value to add a `vot` to the ID token. Prior to this commit this code expected a string representation of a single VoT and not a JSON encoded list. This commit addresses the issue and adjustst the tests to have the correct expectations. [skip changelog]
theabrad
approved these changes
Feb 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
identities.vtrcolumn has one of the following values:vtrparam if thevtrparam is consumed and usedNilThe
IdTokenBuilderuses this value to add avotto the ID token. Prior to this commit this code expected a string representation of a single VoT and not a JSON encoded list. This commit addresses the issue and adjustst the tests to have the correct expectations.