Conversation
amirbey
force-pushed
the
amirbey/LG-12308-selfie-image-source-validation
branch
from
037e3db to
379611f
Compare
amirbey
requested review from
a team,
dawei-nava and
night-jellyfish
and removed request for
a team
amirbey
changed the title
There was a problem hiding this comment.
LGTM.
But I do have a question. When I do testing on desktop, the upload part is hidden on hybrid handoff page.
@amirbey , sorry, i had some stale files.
There was a problem hiding this comment.
I tried this locally and it worked! 🎉 I did have to make sure these two flags were set:
doc_auth_selfie_capture_enabled: true
doc_auth_selfie_desktop_test_mode: false
I also saw some strange behavior that was perhaps a fluke or the gift card I was using. When I first tried using the SDK after failing the upload I saw:
- only tap to capture as an option
- a few "image is blurry" failures
- second time I was able to use autocapture instead of tap to capture and I'm not clear why
- the selfie autocapture was very slow and strange for me
Again these are probably something I did somehow as I don't see a cause for these issues in this code. But I wanted to note here in case it is a pattern.
There was a problem hiding this comment.
yes... you're right on the FF settings to trigger a failure 👍🏿
night-jellyfish
left a comment
night-jellyfish
left a comment
There was a problem hiding this comment.
Tested locally and saw success. Some odd things happened that I noted as a comment, but as they were likely my local issues rather than this work, I am approving.
…e uploaded by sdk when selfie is required changelog: Upcoming Features, Document Authentication, Ensure all doc auth images are sourced by sdk when liveness check is required
amirbey
force-pushed
the
amirbey/LG-12308-selfie-image-source-validation
branch
from
4e1cf54 to
1e6982f
Compare
3 participants
🎫 Ticket
LG-12308
🛠 Summary of changes
Add image upload validation to verify tha image files are all sourced by sdk when doc auth with selfie is required.
📜 Testing Plan