LG-11703 Remove redundant queries from MKMR#10163
Merged
ThatSpaceGuy merged 2 commits intomainfrom Feb 27, 2024
Merged
Conversation
zachmargolis
approved these changes
Feb 26, 2024
olatifflexion
approved these changes
Feb 26, 2024
Contributor
|
we need to rebase/sync this off main to fix the security vuln warning |
changelog: Internal, Reporting, Query once per time range in MKMR
ThatSpaceGuy
force-pushed
the
LG-11703-Fix-MKMR-changing-numbers
branch
from
e463efe to
82b7060
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changelog: Internal, Reporting, Query once per time range in MKMR
🎫 Ticket
Link to the relevant ticket:
LG-11703
🛠 Summary of changes
Changed the Active Users Reports within the MKMR to only query once per time range instead of re-querying the same time range data multiple times - and risking that the underlying data has changed between duplicate queries.