Skip to content

LG-12138 add updated hints for florida id#10149

Merged
svalexander merged 8 commits intomainfrom
shannon/lg-12138-fl-hint-text
Feb 27, 2024
Merged

LG-12138 add updated hints for florida id#10149
svalexander merged 8 commits intomainfrom
shannon/lg-12138-fl-hint-text

Conversation

@svalexander
Copy link
Contributor

@svalexander svalexander commented Feb 23, 2024

🎫 Ticket

Link to the relevant ticket:
LG-12138

🛠 Summary of changes

Add updated Florida specific hint text for state id.

📜 Testing Plan

Provide a checklist of steps to confirm the changes.

  • Go through ipp flow and arrive at state id page
  • Select "Florida" from Issuing-state drop down
  • Verify that new hint text shows

👀 Screenshots

If relevant, include a screenshot or screen capture of the changes.

En, default: Screen Shot 2024-02-23 at 6 03 56 PM
En, full screen: Screen Shot 2024-02-23 at 6 04 15 PM
En, small screen: Screen Shot 2024-02-23 at 6 05 08 PM
Es, default: Screen Shot 2024-02-23 at 6 05 33 PM
Es, full screen: Screen Shot 2024-02-26 at 6 59 11 PM
Es, small screen: Screen Shot 2024-02-26 at 6 59 21 PM
Fr, default: Screen Shot 2024-02-23 at 6 06 35 PM
Fr, full screen: Screen Shot 2024-02-23 at 6 06 47 PM
Fr, small screen: Screen Shot 2024-02-26 at 6 56 56 PM

@svalexander svalexander requested review from a team, JackRyan1989 and allis-green and removed request for a team February 23, 2024 15:26
Copy link
Contributor

@JackRyan1989 JackRyan1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me! Tested locally with no issues.

@gina-yamada
Copy link
Contributor

gina-yamada commented Feb 23, 2024

What does AC Make sure that the line break does not cut the sentence mean? With smaller screens the sentence will naturally move to the next line. Is the goal here to always start "Example.." on a new line?

@carmenrosalop carmenrosalop requested review from carmenrosalop and removed request for allis-green February 23, 2024 16:16
@carmenrosalop
Copy link

Screenshot 2024-02-23 at 8 14 53 AM
@svalexander the implementation looks good! I see that the text implemented has a line break that is shorter than the full width of the component. Is it possible to make the text box the same width as the component? Here's a picture of how it should look like

@aduth
Copy link
Contributor

aduth commented Feb 23, 2024

What does AC Make sure that the line break does not cut the sentence mean? With smaller screens the sentence will naturally move to the next line. Is the goal here to always start "Example.." on a new line?

In the past we've used non-breaking spaces to prevent a linebreak from occurring within a specific set of words that are meant to kept on the same line. I'd imagine that's what the AC is referring to, which I'm not seeing in code. It may not break at certain screen sizes, but we could guarantee this by adding some   in the strings, similar to what we've done elsewhere:

new_backup_codes_html: I need new backup codes

@gina-yamada gina-yamada self-requested a review February 27, 2024 15:58
Copy link
Contributor

@gina-yamada gina-yamada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Translations are accurate. Default working as expected. Florida hint text displaying when Florida is picked. Approving code changes as design will need to review/approve layout.

Copy link

@carmenrosalop carmenrosalop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you Shannon!

@svalexander svalexander merged commit d6408b8 into main Feb 27, 2024
@svalexander svalexander deleted the shannon/lg-12138-fl-hint-text branch February 27, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants