LG-12321: Log TrueIDResponse Identifiers for Troubleshooting#10118
LG-12321: Log TrueIDResponse Identifiers for Troubleshooting#10118
Conversation
| vendor:, | ||
| conversation_id:, | ||
| reference_id:, | ||
| reference:, |
There was a problem hiding this comment.
This seems weird to me, I suspect I should either remove this or use it?
There was a problem hiding this comment.
Hmm I'm not quite sure I understand your question.
My understanding is that this file is mostly for documentation. So including this here is a way of calling it out instead of just passing it through **extra. Maybe that's not helpful to your question though.
I am actually surprised it would just be this one event changed though. With it being included on extra_attributes it seems like other events might now have this as well.
There was a problem hiding this comment.
Hm, well the A/C only mentions this one event. Agreed that it's probably available for other events too.
There was a problem hiding this comment.
Oh sorry I think I wasn't clear - I thought maybe the it was being included in other events on accident. But I just ran through it and didn't see it in other events. So I think it was just me misunderstanding the scope of the code changes. I think only including it on this event is the right choice given the ticket.
night-jellyfish
left a comment
There was a problem hiding this comment.
I ran through the test changes and it all worked as expected!
I think one possible change could be including it in the MockProofer - right now the request_id is null no matter success or failure locally. But I don't think that's blocking this work.
🎫 Ticket
https://cm-jira.usa.gov/browse/LG-12321
🛠 Summary of changes
Add the various
TrueIDResponseidentifiers to the successful result. This was much easier because we were already logging them for the failed result.📜 Testing Plan
'IdV: doc auth image upload vendor submitted'event.request_idfield if this PR worked.