LG-12306: selfie standardflow check#10112
Conversation
dawei-nava
requested review from
amirbey,
charleyf,
eileen-nava and
night-jellyfish
|
Looks great @dawei-nava 👍🏿 i made a few suggestions on the subbing for forcing selfie capture to be more inline with how we check for selfie using decorated_sp_session in the controller. Also, could be great if you could add some feature testing 👍🏿 |
@amirbey , still working on some tests. |
dawei-nava
force-pushed
the
dwang/LG-12306_selfie_standardflow_check
branch
2 times, most recently
from
cfb4817 to
4aaa529
Compare
There was a problem hiding this comment.
Maybe it worth considering to inject sp_ession/decoreate_sp_session or even the controller itself into step preconditions, since we may need more and more context information to make decisions.
|
LGTM @dawei-nava 👍🏿 |
@amirbey , added a config flag to allow desktop selfie mode. Set to true in dev and testing. |
dawei-nava
force-pushed
the
dwang/LG-12306_selfie_standardflow_check
branch
3 times, most recently
from
7b00f29 to
88dc95c
Compare
There was a problem hiding this comment.
@dawei-nava - what is the intended outcome of the flag in the hybrid handoff precondition?
There was a problem hiding this comment.
@amirbey Was talking with Jack from Team Joy, it is kind of complicated when involves the self.select_remote part, the desktop_selfie_test_mode_enabled? is to allow we land on hand off page for testing.
There was a problem hiding this comment.
I wonder if I'm missing a setup step, but when I check out this branch and try running through the testing steps, I did not see the expected result.
Specifically, on desktop, I was not re-directed to the hybrid handoff page. Instead I was able to continue to the upload page.
There was a problem hiding this comment.
@night-jellyfish , you have to set doc_auth_selfie_desktop_test_mode: false
There was a problem hiding this comment.
Ohh okay. I missed that note somehow. Thanks! I can try again later today if you'd like (quite a few meetings this am) but don't need to block it.
…p, mainly for testing purpose.
dawei-nava
force-pushed
the
dwang/LG-12306_selfie_standardflow_check
branch
from
9f081b1 to
23c5fe8
Compare
dawei-nava
force-pushed
the
dwang/LG-12306_selfie_standardflow_check
branch
from
23c5fe8 to
21e1da0
Compare
|
|
||
| context 'opted in to ipp flow' do | ||
| before do | ||
| allow(IdentityConfig.store).to receive(:doc_auth_selfie_desktop_test_mode). |
spec/features/idv/analytics_spec.rb
Outdated
| allow(IdentityConfig.store).to receive(:des). | ||
| and_return(true) |
There was a problem hiding this comment.
where can I find des ?... i am unable to locate this 🤔
There was a problem hiding this comment.
@amirbey , oooh, my IDE completion is too aggressive.
| end | ||
|
|
||
| let(:happy_selfie_path_events) do | ||
| let(:happy_mobile_selfie_path_events) do |
| allow_any_instance_of(FederatedProtocols::Oidc). | ||
| to receive(:biometric_comparison_required?). | ||
| and_return({ biometric_comparison_required: true }) | ||
| and_return(true) |
| before do | ||
| allow_any_instance_of(FederatedProtocols::Oidc). | ||
| to receive(:biometric_comparison_required?). | ||
| and_return({ biometric_comparison_required: true }) |
There was a problem hiding this comment.
| and_return({ biometric_comparison_required: true }) | |
| and_return(true) |
3 participants
🎫 Ticket
Link to the relevant ticket:
LG-12306
🛠 Summary of changes
In document capture controller precondition, prevent entering document capture controller from hybrid handoff if selfie enabled. Based on @amirbey's work.
A config item
doc_auth_selfie_desktop_test_modeto allow enable selfie on desktop. Default isfalsefor production,truefor local dev and testing.📜 Testing Plan
Provide a checklist of steps to confirm the changes.
Note: for local set
doc_auth_selfie_desktop_test_mode: false