Remove unused @ial ivar from Users::SessionsController#10083
Merged
Conversation
This ivar is part of a conditional that is used to determine if the link to authenticate with a PIV or CAC is visible. It was added here: ccc40ed#diff-cd2d90708a775a9fc605178934b17b6cb5d14d4396b06b916a84c43b1b2abd88R37 The computation for this value looks like this: ```ruby def sp_session_ial sp_session[:ial].presence || 1 end ``` This will always have a truthy value unless the requested IAL is IALMax. After reading through the commit history I beleive this IALMax behavior is unintentional. I believe this value was originally intended to require the user to enter a password if identity proofing was required. It appears this requirement changed but the ivar was left behind. This commit removes it. [skip changelog]
aduth
reviewed
Feb 14, 2024
Contributor
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
I think we can remove this as well?
aduth
approved these changes
Feb 14, 2024
Contributor
Wouldn't |
Contributor
Author
Yep, my bad. Turns out this did absolutely nothing. I'll fix the PR message when I merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ivar is part of a conditional that is used to determine if the link to authenticate with a PIV or CAC is visible.
It was added here: ccc40ed
The computation for this value looks like this:
This will always have a truthy value unless the requested IAL is IALMax (the integer value corresponding to IALMax is 0). After reading through the commit history I beleive this IALMax behavior is unintentional.
I believe this value was originally intended to require the user to enter a password if identity proofing was required. It appears this requirement changed but the ivar was left behind. This commit removes it.