LG-12370: success_status to check if pii exists#10077
Merged
Conversation
[skip changelog]
amirbey
changed the title
Contributor
Author
|
Created ticket to address the errored document capture page that appears after PII fails. This issue already existed: 
|
amirbey
force-pushed
the
amirbey/LG-12370-dcr-success-status
branch
from
ebb6f13 to
7bf7059
Compare
dawei-nava
reviewed
Feb 13, 2024
| def success_status | ||
| # doc_auth_success : including document, attention_with_barcode and id type verification | ||
| !!doc_auth_success && selfie_status != :fail | ||
| !!doc_auth_success && selfie_status != :fail && !!pii |
Contributor
There was a problem hiding this comment.
This does check pii completely not available but not partially pii failure?
Contributor
Author
There was a problem hiding this comment.
pii doesn't exist if it's not valid
dawei-nava
approved these changes
Feb 13, 2024
Contributor
dawei-nava
left a comment
dawei-nava
left a comment
There was a problem hiding this comment.
LGTM.
Really want to get to the bottom of it, but dont think it makes things worse and does provide fix for some scenarios.
solipet
pushed a commit
that referenced
this pull request
Feb 13, 2024
* document capture success status to check if pii exists [skip changelog] * happy linting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
LG-12370
🛠 Summary of changes
success_status to check if pii exists
📜 Testing Plan