Conversation
zachmargolis
approved these changes
Feb 12, 2024
lib/reporting/mfa_report.rb
Outdated
Comment on lines
127
to
141
Contributor
There was a problem hiding this comment.
I like the idea of dynamically generating these, but seeing as there's so many exceptions (skipping "remember device" above, renaming personal key, etc), WDYT of just having one big string where the entire query is written out? might be easier to debug?
Contributor
Author
There was a problem hiding this comment.
i don't love either way, so happy to make it a big string instead!
lib/reporting/mfa_report.rb
Outdated
Comment on lines
19
to
25
Contributor
There was a problem hiding this comment.
I get that it matches the structure of other reports, but since there's just one event (and likely not to change?) maybe we just make it EVENT singular constant and just use that?
Jeremy1026
approved these changes
Feb 13, 2024
zachmargolis
approved these changes
Feb 13, 2024
Sgtpluck
force-pushed
the
dmm/lg-11648/mfa-report
branch
from
690ebf9 to
6620b3b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-11648
🛠 Summary of changes
This change adds an MFA Method report. The report only tracks successful authentications that do not include the initial MFA setup, or reauthentication, as per the TK-Health dashboard