LG-12445: Attention to Barcode does not override a failed portrait match

[amirbey]

🎫 Ticket

LG-12445

🛠 Summary of changes

Remove all_passed which is redundant
Update result_success so that Attention to Barcode does not override portrait match failure.

📜 Testing Plan

Unit tests added

[night-jellyfish]

I had one clarifying question.

Otherwise, I looked through the code and couldn't find any other uses of all_passed?. I ran spec/services/doc_auth/lexis_nexis/responses/true_id_response_spec.rb locally and it all still passed. Looking at the specs there, I couldn't think of another test that should be added due to this change. So pending CI passing this looks good to me.

Edit: CI did pass! I just didn't realize it ran on drafts so didn't look closely enough for it.

[night-jellyfish]

LGTM!

[night-jellyfish]

Hmm I'm sorry to wave back on my approval @amirbey, after reviewing a comment by @eileen-nava on the previous iteration of this code, I'm not sure this change would cover the attention_with_barcode? case (tagged you in the conversation on the doc).

I did find when changing the logic to all_passed? to account for selfie, that this successful_result? didn't have tests. I added them for the selfie, but I wonder if now with all these questions on the logic, if we really need to add tests for the other cases (ie, no selfie but attention with barcode, etc).

I wasn't sure if I should change my review to "request changes", but I'm not sure if that should / could be a separate ticket.

[night-jellyfish]

Thank you for adding the tests!

I tested using the original testing plan and after talking with Amir, realized we found a FE issue regarding the error show. We will need to make a ticket for that issue. But as that issue is not because of this work, it's not a blocker.

Re-approving!