Convert file-base64-cache.js to typescript#10070
Merged
night-jellyfish merged 2 commits intomainfrom Feb 12, 2024
Merged
Conversation
night-jellyfish
commented
Feb 10, 2024
app/javascript/packages/document-capture/context/file-base64-cache.ts
Outdated
Show resolved
Hide resolved
aduth
approved these changes
Feb 12, 2024
Contributor
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
One suggestion, but otherwise LGTM 👍
[skip changelog] Co-authored-by: Amir Reavis-Bey <amir.reavis-bey@gsa.gov>
…ache.ts Co-authored-by: Andrew Duthie <1779930+aduth@users.noreply.github.com>
night-jellyfish
force-pushed
the
js-to-ts-brittany-amir-file-base64-cache
branch
from
9c8bd30 to
8c17c7c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Converting
file-base-64-cache.jsto typescript.