LG-12332: fix mock client to pass when using real image.#10066
Merged
dawei-nava merged 3 commits intomainfrom Feb 13, 2024
Merged
LG-12332: fix mock client to pass when using real image.#10066dawei-nava merged 3 commits intomainfrom
dawei-nava merged 3 commits intomainfrom
Conversation
dawei-nava
requested review from
amirbey,
charleyf,
eileen-nava and
night-jellyfish
dawei-nava
force-pushed
the
dwang/LG-12332-image-pass-mock
branch
2 times, most recently
from
b66f282 to
c799a35
Compare
charleyf
approved these changes
Feb 13, 2024
Contributor
charleyf
left a comment
charleyf
left a comment
There was a problem hiding this comment.
Tested this and it allows uploading of a selfie image (using the mock proofer).
Contributor
There was a problem hiding this comment.
I think it's clearer to use one of these or the other.
I have a slight preference for this: selfie_required: liveness_checking_required,
Contributor
Author
There was a problem hiding this comment.
@charleyf , just is thinking about the same and I think I agree.
Contributor
There was a problem hiding this comment.
Looks good! Did a quick test and the image upload still works.
changelog: Internal, Doc Auth, Allow test to pass with selfie image.
dawei-nava
force-pushed
the
dwang/LG-12332-image-pass-mock
branch
from
b9393a7 to
46cd9e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
LG-12332
🛠 Summary of changes
When selfie image(not yaml) attached, mock client failed to pass in dev mode, due to the fact that we default to :not_processed for
selfie_status.So we changed to return
:successif selfie is required and missingportrait_match_resultsinresult_response.