LG-12039: capture session read from new capture session results for document check results#10041
Merged
dawei-nava merged 4 commits intomainfrom Feb 6, 2024
Merged
LG-12039: capture session read from new capture session results for document check results#10041dawei-nava merged 4 commits intomainfrom
dawei-nava merged 4 commits intomainfrom
Conversation
changelog: Internal, Doc Auth, Doc auth TrueID doc_auth_success? should consider all document business logic.
… More appropriate to user helper module. changelog: Internal, Doc Auth, New doc_auth_success? should include business decision.
dawei-nava
requested review from
amirbey,
charleyf,
eileen-nava and
night-jellyfish
eileen-nava
approved these changes
Feb 6, 2024
Contributor
eileen-nava
left a comment
eileen-nava
left a comment
There was a problem hiding this comment.
Approved. Let me know once you have the PR with session changes up and ready to be reviewed. 🙏🏻
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
LG-12039
🛠 Summary of changes
Consider vendor, attention_with_barcode and id_type for
TrueIdResponse.doc_auth_success?First PR for touching session result, since we are changing what is written to doc_auth_success filed in session result, what it was True can be False now or the other way around, to mitigate the risk, use the new logic first.