Conversation
Extracted `request_id`
Extracted `app_session`
Extracted `instance`
Renamed `app_session_hash` to `expected_sp_values`
Extracted `requested_attributes` Renamed `url` to `request_url`
There was a problem hiding this comment.
It looks like request_acr never gets set anywhere. It should be the ial and aal strings separated by a space ( ) when ACR values are used.
There was a problem hiding this comment.
Added specs for this.
There was a problem hiding this comment.
I don't think we need this conditional.
The VOT Parser can handle ACR values. We should be able to pass both the ACR and VOT value into the parser and have it work.
I think the feature flag should prevent us from consuming and storing the VTR param rather than from using it here.
There was a problem hiding this comment.
I just integrated the feature flag into the form where the VTR is consumed here: 1cb5ed4
changelog: Upcoming Features,VOT,Handle vector of trust in SP requests
jmax-gsa
force-pushed
the
jmax/LG-12260-use-authn-context-resolver-to-compute-legacy-sp-session-values
branch
from
dedcecd to
69da264
Compare
Added ACR tests.
| end | ||
|
|
||
| def biometric_comparison_required_value | ||
| parsed_vot.biometric_comparison? |
There was a problem hiding this comment.
Here I think we want to look at parsed_vot.biometric_comparison? || sp_request.biometric_comparison_required. Since the current biometric comparison API is experimental and exists outside of the acr_values and vtr params we'll need to look at what is on the SP request until we update the sample OIDC SP.
Pulled lets up a level
Made sp_request creation calls identical
Added use_vot_in_sp_requests let
…compute-legacy-sp-session-values
Per conversation w/ Hooper
spec/controllers/openid_connect/authorization_controller_spec.rb
Outdated
Show resolved
Hide resolved
jmax-gsa
deleted the
jmax/LG-12260-use-authn-context-resolver-to-compute-legacy-sp-session-values
branch
2 participants
🎫 Ticket
LG-12260
🛠 Summary of changes
Use the new
AuthnContextResolverto translate vector of trust style SP requests into legacy values in the SP session.📜 Testing Plan
Provide a checklist of steps to confirm the changes.
spec/services/store_sp_metadata_in_session_spec.rball pass.