Conversation
|
The re-shuffling of exports from |
I came up with an approach that works, though I'm not thrilled about the changes to The most compelling alternative is to find a way to override the default analytics behavior in the test environment, maybe by exposing some additional properties/configuration from the analytics package. Challenge is trying to find an elegant way to do this which isn't too distinct between environments to risk desync issues, and which keeps the package lean enough that test-env specific code doesn't unnecessarily inflate the end-user download size. |
|
To avoid dealing with the JavaScript stubbing issue, b3bba00 switches back to the original |
changelog: Internal, Error Logging, Log filename in frontend error logging
Avoid dealing with dependency stubbing issue
b3bba00 to
c187257
Compare
🛠 Summary of changes
Updates frontend error logging to include the
ErrorEvent#filenameproperty, if applicable.Previously, this was typically assumed to be made available via the existing
stacklog detail, but this is not always included depending on the browser.This detail will help validate a hypothesis that current errors being logged are originating from files not expected to be eligible for logging via
isTrackableErrorEvent.📜 Testing Plan
echo "setTimeout(() => { throw new Error('example'); }, 100)" >> app/javascript/packages/analytics/index.tsNODE_ENV=production yarn buildrails s