Remove OS version from new device mailer preview#10012
Merged
Conversation
changelog: Internal, Mailer Previews, Sync new device mailer preview content to live content
kevinsmaster5
approved these changes
Jan 31, 2024
Contributor
kevinsmaster5
left a comment
kevinsmaster5
left a comment
There was a problem hiding this comment.
Looks good to me! 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Updates the content for the new device mailer preview to more realistically match what a real user would receive.
As of #9904 (LG-11899), we no longer include operating system version in device names, so the example content "macOS 123" should be stripped of the version identifier.
An alternative approach could be to use the actual parsed device name from the current request user agent, which would help keep this more guaranteed as in-sync, but is perhaps too real / identifying to the current browser?
📜 Testing Plan