This repository was archived by the owner on Apr 22, 2021. It is now read-only.
Make sure to send pii_from_doc in ProofDocument, ProofDocumentMock#43
Merged
zachmargolis merged 2 commits intomasterfrom Nov 27, 2020
Merged
Make sure to send pii_from_doc in ProofDocument, ProofDocumentMock#43zachmargolis merged 2 commits intomasterfrom
zachmargolis merged 2 commits intomasterfrom
Conversation
**Why**: GetResultsResponse#to_h (from identity-doc-auth) intentionally excludes to prevent accidental logging
stevegsa
reviewed
Nov 27, 2020
| end | ||
|
|
||
| result = proofer_result.to_h | ||
| # pii_from_doc is excluded from to_h to prevent accidental logging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: GetResultsResponse#to_h (from identity-doc-auth)
intentionally excludes to prevent accidental logging
@aduth's comment (18F/identity-idp#4464 (comment)) prompted me to check in why we weren't receiving PII, and the answer was because we exclude PII from
#to_hintentionally: https://github.com/18F/identity-doc-auth/blob/ac9f43820717343788ea6e0dfb9f75f8ec610f8d/lib/identity_doc_auth/acuant/responses/get_results_response.rb#L27-L40