Skip to content

Allow skipping remote config #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mitchellhenke merged 2 commits into from
Jul 25, 2023
Merged

Allow skipping remote config #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
56acfd7
Allow skipping remote config
Jul 25, 2023
9bd243d
bump version
Jul 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/identity/hostdata/config_reader.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ def default_configuration

def app_override_configuration
local_config_filepath = File.join(app_root, 'config', 'application.yml')
raw_configs = if Identity::Hostdata.in_datacenter?
raw_configs = if Identity::Hostdata.in_datacenter? && !ENV['LOGIN_SKIP_REMOTE_CONFIG']
app_secrets_s3.read_file(app_configuration_s3_path)
elsif File.exist?(local_config_filepath)
File.read(local_config_filepath)
Expand All @@ -62,7 +62,7 @@ def role_override_configuration
return {} if role_configuration_filename.nil?
local_config_filepath = File.join(app_root, 'config', role_configuration_filename)

raw_configs = if Identity::Hostdata.in_datacenter?
raw_configs = if Identity::Hostdata.in_datacenter? && !ENV['LOGIN_SKIP_REMOTE_CONFIG']
app_secrets_s3.read_file(role_configuration_s3_path)
elsif File.exist?(local_config_filepath)
File.read(local_config_filepath)
Expand Down
2 changes: 1 addition & 1 deletion lib/identity/hostdata/version.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# frozen_string_literal: true
module Identity
module Hostdata
VERSION = '3.4.1'
VERSION = '3.4.2'
end
end