Add meta charset to documentation layout to fix visual regressions tests#361
Merged
Add meta charset to documentation layout to fix visual regressions tests#361
Conversation
jmdembe
approved these changes
Jun 16, 2023
Contributor
|
Looking around, it seems like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There have been some visual regression failures on recent pull requests related to content encoding (see #359 (comment)). Based on my understanding, it doesn't seem like this tag should be necessary, as
utf-8should already be the default for HTML5 documents. But it does appear to have a positive effect, where builds appear to be passing again (after 4 retries).