Fix Process List "Big" variant showing connected line#357
Merged
Conversation
26d996b to
68d4255
Compare
68d4255 to
dfffaec
Compare
|
@aduth I think the federalist link for testing the fix per the instructions expired |
Contributor
Author
|
Ok sweet, and the live test is working on my end. All looks good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merges to (blocked by) #356Fixes an issue where Process List "Big" variant would show with the connected line when not rendered in prose content.
Issue can be seen here ("Big" should not show line): https://idp.dev.identitysandbox.gov/components/inspect/process_list/preview
Issue can't be seen here, since design system documentation is shown in
.usa-prose: https://design.login.gov/components/process-list/#bigThe underlying issue is a CSS specificity conflict, where the styles responsible for unsetting the border width were only strong enough to override the previous border width styling when rendered inside
.usa-prose, but not when rendered outside.usa-prose. The changes here make it so that the "Big" border is only applied to the connected process list.Testing Instructions:
document.querySelector('.usa-prose').classList.remove('usa-prose')