Skip to content

Add SVG optimization lint to build#307

Merged
aduth merged 2 commits intomainfrom
aduth-svg-lint
Mar 25, 2022
Merged

Add SVG optimization lint to build#307
aduth merged 2 commits intomainfrom
aduth-svg-lint

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented Mar 25, 2022

See: #306 (comment)

Why: So that images included with the design system are as lean as they can be, so that they load quickly.

Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from aduth-icon-bg-success-color to main March 25, 2022 17:42
@aduth
Copy link
Contributor Author

aduth commented Mar 25, 2022

Visual regression test seems to be using the result of #306, likely because this branch was initially set to merge to that one. Going to assume it's all clear, since there's not intended to be visual changes here. The test will run again on main anyways.

@aduth aduth merged commit 9a60024 into main Mar 25, 2022
@aduth aduth deleted the aduth-svg-lint branch March 25, 2022 18:10
@aduth aduth mentioned this pull request Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants